Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better 'loading messages' indicator #237

Closed
borisyankov opened this issue Jan 27, 2017 · 3 comments · Fixed by #247
Closed

Better 'loading messages' indicator #237

borisyankov opened this issue Jan 27, 2017 · 3 comments · Fixed by #247
Assignees
@neerajwahi
Milestone
M7

Comments

@borisyankov
Copy link
Contributor

When loading a new narrow use the current '5 loading messages' visual.
When loading messages from top or bottom, show an ActivityIndicator on top or bottom respectively.
@borisyankov borisyankov added this to the M6 milestone Jan 27, 2017
@neerajwahi
Copy link
Member

I experimented with using the black Zulip loading indicator from the web app. It works pretty well. Will open a PR

@neerajwahi neerajwahi self-assigned this Jan 27, 2017
@borisyankov
Copy link
Contributor Author

What did you use to load the svg? Or did you use the Logo component?

@neerajwahi
Copy link
Member

I created a new Loading component. I rendered the SVG to PNG and used the Animation API

@neerajwahi neerajwahi mentioned this issue Jan 27, 2017
Merged
neerajwahi added a commit that referenced this issue Jan 27, 2017
@neerajwahi
Improve loading indicators and fix fetching / caught-up logic. (#247)
b7b3263 
Fixes #237 and fixes #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neerajwahi neerajwahi

Labels
None yet
Projects
None yet
Milestone
M7
Development

Successfully merging a pull request may close this issue.

Improve loading indicators and fix fetching / caught-up logic.
2 participants
@borisyankov @neerajwahi