Skip to content

Commit

Permalink
AccountDetails: Show name instead of email.
Browse files Browse the repository at this point in the history
This brings this UI in line with the corresponding UI in the webapp,
which is the card that pops up on clicking on a user's name or avatar.

The user's email address can be helpful information, but their name is
usually more helpful.  Also, under an org setting that's currently in
beta after being a frequent request for a long time, users' real email
addresses won't even be available to normal users -- so the `email`
property will be an opaque address made up by the server.  (See #3196.)
So we certainly don't want to show that here.

While we're here, also swap the order of the name and the status
indicator, again following the webapp.
  • Loading branch information
gnprice committed Jul 15, 2019
1 parent bd6c155 commit 9d020c8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/account-info/AccountDetails.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ class AccountDetails extends PureComponent<Props, void> {
/>
</View>
<View style={componentStyles.statusWrapper}>
<RawLabel style={[styles.largerText, styles.halfMarginRight]} text={user.full_name} />
<PresenceStatusIndicator email={user.email} hideIfOffline={false} />
<RawLabel style={[styles.largerText, styles.halfMarginLeft]} text={user.email} />
</View>
{userStatusText !== undefined && (
<RawLabel
Expand Down

0 comments on commit 9d020c8

Please sign in to comment.