Skip to content

Commit

Permalink
android: Follow RN's removal of pickFirst arguments.
Browse files Browse the repository at this point in the history
Part of the RN v0.62 -> v0.63 changes to the template app [1],
corresponding to facebook/react-native@4bb0b4f20.

These lines (which we added in cb56f16, for
facebook/react-native@2fd50882b) are reportedly "no longer necessary
with the new Flipper release".

It would have been nice if they specified which Flipper release. At
that commit, the Flipper version in use is 0.30.2, so it probably
would have been safe to make this change for quite a while -- but
might as well do it now, after having just taken a big leap in
Flipper versions well beyond that.

[1] https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.4
[2] https://github.com/facebook/react-native/blob/4bb0b4f20/template/android/gradle.properties#L28
  • Loading branch information
chrisbobbe committed Dec 1, 2020
1 parent 5d68399 commit 86ab92d
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,6 @@ android {
}
}

packagingOptions {
pickFirst "lib/armeabi-v7a/libc++_shared.so"
pickFirst "lib/arm64-v8a/libc++_shared.so"
pickFirst "lib/x86/libc++_shared.so"
pickFirst "lib/x86_64/libc++_shared.so"
}

// applicationVariants are e.g. debug, release
applicationVariants.all { variant ->
variant.outputs.each { output ->
Expand Down

0 comments on commit 86ab92d

Please sign in to comment.