Skip to content

Commit

Permalink
notifs [nfc]: Ensure tests pass with representative pm_users values.
Browse files Browse the repository at this point in the history
To be reverted in the next commit.

The output of GroupPm.getPmUsersString in our Kotlin code was
actually a string of numbers separated by ', ' instead of ',' as we
expected. Ensure that our tests pass with ', ' before changing the
Kotlin code to use ','.
  • Loading branch information
Chris Bobbe committed Feb 21, 2020
1 parent ec1290f commit 299d6fc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/notification/__tests__/notification-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('getNarrowFromNotificationData', () => {
test('on notification for a group message returns a group narrow', () => {
const notification = {
recipient_type: 'private',
pm_users: '1,2,4',
pm_users: '1, 2, 4',
};
const usersById = new Map([
[1, { email: '[email protected]' }],
Expand All @@ -47,7 +47,7 @@ describe('getNarrowFromNotificationData', () => {
test('do not throw when users are not found; return null', () => {
const notification = {
recipient_type: 'private',
pm_users: '1,2,4',
pm_users: '1, 2, 4',
};
const usersById = new Map();

Expand Down

0 comments on commit 299d6fc

Please sign in to comment.