Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

good first issue solved #1093

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

good first issue solved #1093

wants to merge 2 commits into from

Conversation

yoBoyio
Copy link
Collaborator

@yoBoyio yoBoyio commented Mar 24, 2021

This solves #1087 issue, spacing between tooltips of organisations.
Tested on Ubuntu
Zulip-Desktop Version 5.6.0

zulip_good_1st_issue

@timabbott
Copy link
Member

Thanks for working on this @yoBoyio and welcome! This looks reasonable but needs a proper commit message.

Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

@Ayushsunny
Copy link
Collaborator

Ayushsunny commented Mar 25, 2021

Thanks for working on this @yoBoyio and welcome! This looks reasonable but needs a proper commit message.

Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

Hello @timabbott Sir, I have already made the PR earlier than him but you are considering his PR why sir? #1091 (comment)

@yoBoyio
Copy link
Collaborator Author

yoBoyio commented Mar 25, 2021

@timabbott Thank you for the details, can I try again?

@zulipbot
Copy link
Member

zulipbot commented Apr 9, 2022

Heads up @yoBoyio, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants