YouTube videos not playing in app

[Yogislav]

Since 2.3.5 update I cannot play youtube videos in zulip. Whenever someone sends something and I click the thumbnail, whole screen turns black (as it usually was) but player is not visible.

---

• Operating System:
  • Windows
  • Linux/Ubutnu
  • macOS
• Clear steps to reproduce the issue:

1. Send any YouTube video;
2. Click on thumbnail;
3. Stare at black screen;

[abhigyank]

Can reproduce on CZO in Ubuntu. Not reproducible on browser, only on the desktop app.

[timabbott]

This seems likely related to the click handler overriding for uploaded files logic.

[timabbott]

Look for the code around is_youtube_video in static/js/lightbox.js in the webapp to see how the youtube player is triggered.

[akashnimare]

This used to work until the v2.3.2. @abhigyank there is some corner case which we missed.

[Yogislav]

I believe it worked even until further version. It's only after 2.3.5 update that it stopped working for me.

[timabbott]

@akashnimare how does zulip/zulip-electron@6470f53 resolve this?

[abhigyank]

@timabbott 7299cd5 broke this for some reason (it works for all commits before this one). It was due to the sentry module breaking it somehow. Updating sentry to the latest version seems to fix this.

[timabbott]

OK, cool; you should definitely be putting that context in the commit message!