Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt+Shifts opens upper menu but we use that shortcut to switch languages. #528

Closed
1 of 3 tasks
winmasta opened this issue Jul 26, 2018 · 18 comments
Closed
1 of 3 tasks

Comments

@winmasta
Copy link

winmasta commented Jul 26, 2018


  • Operating System:
    • Windows
    • Linux/Ubutnu - Mint 18.3
    • macOS
  • Clear steps to reproduce the issue:
    1.Run application
    2.Choose any chat or stream by clicking on it
    3.Put cursor to message entry window
    4.Press Alt+Shift
  • Relevant error messages and/or screenshots:
    default

Input language switch expected, but File menu opened and there is no ability to continue typing message. It could be very useful to disable Zulip Alt+Shift keyboard shortcut.

@abhigyank
Copy link
Collaborator

abhigyank commented Jul 26, 2018

Hi @winmasta I couldn't reproduce this on Ubuntu 16.04. Zulip doesn't specifically use Alt+Shift to open File Menu i.e. this is not a Zulip level shortcut. I'd assume this is something Mint does by itself. I am not sure if we can explicitly stop this.
Maybe you can check the shortcuts in Mint System Preferences - > Keyboard.

@winmasta
Copy link
Author

I have checked all OS shortcuts and didn't find Alt+Shift, moreover I am using Mint for more than 5 years already and never faced with such problem, moreover it affects only Zulip app.

@akashnimare
Copy link
Member

@winmasta I can successfully switch the language using the Alt+Shift key combination on Ubuntu 16.04. You may find that shortcut in keyboard setting, please see. Also, can you switch language using the same shortcut in other apps?

@winmasta
Copy link
Author

@akashnimare Yes I can switch the language anywere but Zulip app. Trying to switch language in Zulip app leads to throwing down upper menu of the app.
default

@akashnimare
Copy link
Member

Okay. This looks like an upstream issue and for some reason, it doesn't work in the mint os. I'll file an issue there and will look for the potential solution.

@winmasta
Copy link
Author

Thanks.

@baumnkz
Copy link

baumnkz commented Sep 13, 2018

I'm using Linux Mint 18.3 and Zulib desktop, and I have the same problem.

In other applications have already solved this problem:
RocketChat/Rocket.Chat.Electron@5b684bb

ramboxapp/community-edition#432

@baumnkz
Copy link

baumnkz commented Sep 13, 2018

I think, you need to add '&' before menu labels

@akashnimare
Copy link
Member

@baumnkz yeah, let me try the mentioned fix. Are you up for debugging this? I can release a quick beta on Linux.

@baumnkz
Copy link

baumnkz commented Sep 13, 2018

@akashnimare yes, I'm ready to debugging

@akashnimare
Copy link
Member

Okay, thanks. Are you using the .deb installer?

@baumnkz
Copy link

baumnkz commented Sep 13, 2018

Yes, I am

@akashnimare
Copy link
Member

@baumnkz I have published a new beta release for Linux - v2.3.8-beta. You need to run the following in order to get it (you might need to uninstall the stable version first) -

https://zulipchat.com/help/desktop-app-install-guide#linux-with-apt-ubuntu-or-debian-8

@winmasta
Copy link
Author

default
still problem

@baumnkz
Copy link

baumnkz commented Sep 13, 2018

@akashnimare Great! But now one of menu item is hiding - help menu is not visible

When I press Alt+Shift now opened non-labeled menu:
help-menu

@akashnimare
Copy link
Member

akashnimare commented Sep 13, 2018

@baumnkz just fixed it and pushed a new beta. Can you update and check if it works as expected?

@baumnkz
Copy link

baumnkz commented Sep 13, 2018

@akashnimare Great! It works!

@akashnimare
Copy link
Member

Awesome, thanks for the help ❤️

kanishk98 pushed a commit to kanishk98/zulip-desktop that referenced this issue Dec 28, 2018
It's an upstream bug where if you press ALT+SHIFT on
Linux, it opens up the app menu items. The fix is adding
the & to all the menu labels.

Fixes: zulip#528.
kanishk98 pushed a commit to kanishk98/zulip-desktop that referenced this issue Jun 18, 2019
It's an upstream bug where if you press ALT+SHIFT on
Linux, it opens up the app menu items. The fix is adding
the & to all the menu labels.

Fixes: zulip#528.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants