Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats facet doesn't count documents with null values #48

Closed
payammeyer opened this issue Dec 13, 2021 · 1 comment
Closed

Stats facet doesn't count documents with null values #48

payammeyer opened this issue Dec 13, 2021 · 1 comment
Assignees
@payammeyer
Labels
bug

Comments

@payammeyer
Copy link
Contributor

When using FacetStats, if a document has a null value for the faceted field, the document does not get counted in the corpus. This is a problem for cases where a field can legitimately have a null value.
@payammeyer payammeyer added the bug label Dec 13, 2021
@payammeyer payammeyer self-assigned this Dec 13, 2021
@payammeyer
Copy link
Contributor Author

Add allDocCount to FacetStats to account for all documents.

payammeyer added a commit that referenced this issue Dec 13, 2021
@payammeyer
#48 - Added allDocCounts so that documents with null or empty values …
643f919 
…for a facet get counted towards total count.
mdavis95 pushed a commit that referenced this issue Dec 14, 2021
@payammeyer
#48 - Added allDocCounts so that documents with null or empty values …
db5737e 
…for a facet get counted towards total count. (#49)
@mdavis95 mdavis95 closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@payammeyer payammeyer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdavis95 @payammeyer