Integrate Error Prone for static code analysis #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally this check would be executed in a pipeline, but I'm not firm with GitHub actions and the code analysis would require configuration of another JDK. |
|
@cdjackson Would you mind giving it a look. |
|
Thanks @ViToni - looks good. |
ViToni
added a commit
to ViToni/com.zsmartsystems.zigbee
that referenced
this pull request
May 26, 2023
* Add ErrorProne integration * Fix endless recursion due to missing delegation * Fix wrong generic type on Comparable for ZigBeeGroup * Fix wrong computation of hasCode for ZToolAddress64 * Fix wrong key being used for SynchronousCommandListener lookup * Make formatting of Integer explicit
charbopassman
pushed a commit
to passmanSA/com.zsmartsystems.zigbee
that referenced
this pull request
Jul 25, 2024
* Add ErrorProne integration * Fix endless recursion due to missing delegation * Fix wrong generic type on Comparable for ZigBeeGroup * Fix wrong computation of hasCode for ZToolAddress64 * Fix wrong key being used for SynchronousCommandListener lookup * Make formatting of Integer explicit
charbopassman
pushed a commit
to passmanSA/com.zsmartsystems.zigbee
that referenced
this pull request
Jul 25, 2024
* Add ErrorProne integration * Fix endless recursion due to missing delegation * Fix wrong generic type on Comparable for ZigBeeGroup * Fix wrong computation of hasCode for ZToolAddress64 * Fix wrong key being used for SynchronousCommandListener lookup * Make formatting of Integer explicit
charbopassman
pushed a commit
to passmanSA/com.zsmartsystems.zigbee
that referenced
this pull request
Dec 2, 2024
* Add ErrorProne integration * Fix endless recursion due to missing delegation * Fix wrong generic type on Comparable for ZigBeeGroup * Fix wrong computation of hasCode for ZToolAddress64 * Fix wrong key being used for SynchronousCommandListener lookup * Make formatting of Integer explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error Prone provides compile time static code analysis.
It requires at least JDK 11 since it makes use of some compiler hooks which are only available starting with JDK 11.
The setup allows usage of a JDK up to version 15 (version 16 and higher require addtional configuration).
This change does NOT change the default compilation source and target.
To avoid any interference between code analysis and production code, there is a special profile enabling code analysis.
This profile can either be selected explicitly:
or implicitly by injecting a JDK in the version range [11,16)