Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Warnings/Message boxes don't render correctly on the latest version of Firefox #1

Closed
xplshn opened this issue Feb 5, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@xplshn
Copy link

xplshn commented Feb 5, 2024

2024-02-04-224653_830x540_scrot
This is the only browser which I have installed in my PC. So I can't really compare to others, however, I don't think it is supposed to look like that:
Otherwise, really cool project! I will probably make a GTK themese based off of this

@zshall zshall added the bug Something isn't working label Mar 7, 2024
@zshall
Copy link
Owner

zshall commented Mar 7, 2024

Thanks for your report! It appears that this is related to breakpoints in @media queries; in Firefox 122 on Windows it looks like this for me at 1920w:

image

I can reproduce the bug you described in WebKit, at a width of 1200-1400 pixels, so it's very likely related to this:

image

Let me take a look and see what I can find; it's probably going to regard padding on the icon on the left.

As far as GTK theming that sounds great! I envision a future version of this project where you can declare <div class="theme-default shell-gtk"> or shell-3.1 or shell-os9, etc. and we would adapt to it. We'll probably want to reorganize the folder structure to reflect this. I'll write up an issue about getting this done.

@zshall
Copy link
Owner

zshall commented Mar 7, 2024

I've taken a look and implemented some fixes. Added a .btn-group class for dealing with multiple buttons next to each other which spaces them out using gap. I also updated the documentation to add .p-0 classes to the left hand side of alerts so that they work in constrained screen sizes; this also makes them look better positioned. Here's what it looks like on Firefox:

image

@xplshn
Copy link
Author

xplshn commented Mar 8, 2024

Great! I will track this project.

zshall added a commit that referenced this issue Mar 8, 2024
zshall added a commit that referenced this issue Mar 8, 2024
@zshall zshall self-assigned this Mar 8, 2024
@zshall
Copy link
Owner

zshall commented Mar 8, 2024

Published! v1.1.0 is live now.

npm: https://www.npmjs.com/package/shell-css
Docs: https://zachhall.org/shell-css/

Feel free to comment this issue if you run into trouble with the fix.

@zshall zshall closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants