Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed ZIA SSL Inspection Proxy Gateway Attribute #297

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Jan 29, 2025

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 January 29, 2025 06:18 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZCON_ZSCALER_BETA January 29, 2025 06:18 — with GitHub Actions Inactive
@willguibr willguibr self-assigned this Jan 29, 2025
@willguibr willguibr added the bug Something isn't working label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.42%. Comparing base (d4f69fe) to head (0e896d8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   30.42%   30.42%           
=======================================
  Files          40       40           
  Lines        3136     3136           
=======================================
  Hits          954      954           
  Misses       2038     2038           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 January 29, 2025 06:45 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZCON_ZSCALER_BETA January 29, 2025 06:45 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZCON_ZSCALER_THREE January 29, 2025 06:46 — with GitHub Actions Inactive
@willguibr willguibr merged commit c89a43e into master Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

1 participant