Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed OneAPI ZIA Rate Limit Override Panic Issue #296

Merged
merged 1 commit into from
Jan 27, 2025
Merged

fix: Fixed OneAPI ZIA Rate Limit Override Panic Issue #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Changelog

# 3.1.1 (January 27, 2025)

## Notes
- Golang: **v1.22**

### Bug Fixes

[PR #296](https://github.com/zscaler/zscaler-sdk-go/pull/296) - Fixed ZIA Rate limit override issue to prevent inadivertant panic.

# 3.1.0 (January 20, 2025)

## Notes
Expand Down
10 changes: 9 additions & 1 deletion docs/guides/release-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,20 @@ Track all Zscaler SDK GO releases. New resources, features, and bug fixes will b

---

``Last updated: v3.1.0``
``Last updated: v3.1.1``

---

# Changelog

# 3.1.1 (January 27, 2025)

## Notes
- Golang: **v1.22**

### Bug Fixes

[PR #296](https://github.com/zscaler/zscaler-sdk-go/pull/296) - Fixed ZIA Rate limit override issue to prevent inadivertant panic.

## Notes
- Golang: **v1.22**
Expand Down
4 changes: 2 additions & 2 deletions zscaler/oneapiclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,10 @@ func setHttpClients(cfg *Configuration) {
zccRateLimiter := rl.NewRateLimiter(100, 3, 3600, 86400) // General: 100 per hour, downloadDevices: 3 per day

// Default case for unknown or unhandled services
defaultRateLimiter := rl.NewRateLimiter(2, 1, 1, 1) // Default limits
// defaultRateLimiter := rl.NewRateLimiter(2, 1, 1, 1) // Default limits

// Pass the config to getHTTPClient so it can access proxy settings
cfg.HTTPClient = getHTTPClient(cfg.Logger, defaultRateLimiter, cfg)
// cfg.HTTPClient = getHTTPClient(cfg.Logger, defaultRateLimiter, cfg)
cfg.ZIAHTTPClient = getHTTPClient(cfg.Logger, ziaRateLimiter, cfg)
cfg.ZPAHTTPClient = getHTTPClient(cfg.Logger, zpaRateLimiter, cfg)
cfg.ZCCHTTPClient = getHTTPClient(cfg.Logger, zccRateLimiter, cfg)
Expand Down
Loading