Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed subRules attribute in the ZIA package #251

Merged
merged 3 commits into from
May 23, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented May 22, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@willguibr willguibr temporarily deployed to ZCON_ZSCALER_BETA May 22, 2024 22:01 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_QA_TENANT01 May 22, 2024 22:01 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_QA_TENANT02 May 22, 2024 22:01 — with GitHub Actions Inactive
@willguibr willguibr self-assigned this May 22, 2024
@willguibr willguibr added bug Something isn't working zia-new-attributes ZIA API Added New Parameters labels May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 51.44%. Comparing base (6a8f6e3) to head (c845eb7).
Report is 1 commits behind head on master.

Files Patch % Lines
zia/services/devicegroups/devicegroups.go 85.71% 2 Missing and 1 partial ⚠️
zia/services/adminuserrolemgmt/roles/adminroles.go 85.71% 1 Missing ⚠️
...services/location/locationgroups/locationgroups.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   49.07%   51.44%   +2.37%     
==========================================
  Files         271      271              
  Lines        6780     6761      -19     
==========================================
+ Hits         3327     3478     +151     
+ Misses       3009     2820     -189     
- Partials      444      463      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willguibr willguibr temporarily deployed to ZCON_ZSCALER_THREE May 22, 2024 22:02 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 May 22, 2024 22:08 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 May 22, 2024 22:16 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZCON_ZSCALER_THREE May 23, 2024 00:45 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 May 23, 2024 00:48 — with GitHub Actions Inactive
@willguibr willguibr had a problem deploying to ZPA_PROD_TENANT01 May 23, 2024 00:52 — with GitHub Actions Failure
@willguibr willguibr temporarily deployed to ZPA_QA_TENANT01 May 23, 2024 01:10 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_QA_TENANT02 May 23, 2024 01:10 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 May 23, 2024 01:10 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 May 23, 2024 01:10 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZCON_ZSCALER_BETA May 23, 2024 04:20 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_QA_TENANT01 May 23, 2024 04:20 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_QA_TENANT02 May 23, 2024 04:20 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZCON_ZSCALER_THREE May 23, 2024 04:21 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 May 23, 2024 04:24 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 May 23, 2024 04:29 — with GitHub Actions Inactive
@willguibr willguibr merged commit 7ca70e0 into master May 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working zia-new-attributes ZIA API Added New Parameters
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

1 participant