Skip to content

Commit

Permalink
fix: Fixed OneAPI ZIA Rate Limit Override Panic Issue (#296)
Browse files Browse the repository at this point in the history
willguibr authored Jan 27, 2025

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
1 parent bb212b2 commit d4f69fe
Showing 3 changed files with 20 additions and 3 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Changelog

# 3.1.1 (January 27, 2025)

## Notes
- Golang: **v1.22**

### Bug Fixes

[PR #296](https://github.com/zscaler/zscaler-sdk-go/pull/296) - Fixed ZIA Rate limit override issue to prevent inadivertant panic.

# 3.1.0 (January 20, 2025)

## Notes
10 changes: 9 additions & 1 deletion docs/guides/release-notes.md
Original file line number Diff line number Diff line change
@@ -13,12 +13,20 @@ Track all Zscaler SDK GO releases. New resources, features, and bug fixes will b

---

``Last updated: v3.1.0``
``Last updated: v3.1.1``

---

# Changelog

# 3.1.1 (January 27, 2025)

## Notes
- Golang: **v1.22**

### Bug Fixes

[PR #296](https://github.com/zscaler/zscaler-sdk-go/pull/296) - Fixed ZIA Rate limit override issue to prevent inadivertant panic.

## Notes
- Golang: **v1.22**
4 changes: 2 additions & 2 deletions zscaler/oneapiclient.go
Original file line number Diff line number Diff line change
@@ -193,10 +193,10 @@ func setHttpClients(cfg *Configuration) {
zccRateLimiter := rl.NewRateLimiter(100, 3, 3600, 86400) // General: 100 per hour, downloadDevices: 3 per day

// Default case for unknown or unhandled services
defaultRateLimiter := rl.NewRateLimiter(2, 1, 1, 1) // Default limits
// defaultRateLimiter := rl.NewRateLimiter(2, 1, 1, 1) // Default limits

// Pass the config to getHTTPClient so it can access proxy settings
cfg.HTTPClient = getHTTPClient(cfg.Logger, defaultRateLimiter, cfg)
// cfg.HTTPClient = getHTTPClient(cfg.Logger, defaultRateLimiter, cfg)
cfg.ZIAHTTPClient = getHTTPClient(cfg.Logger, ziaRateLimiter, cfg)
cfg.ZPAHTTPClient = getHTTPClient(cfg.Logger, zpaRateLimiter, cfg)
cfg.ZCCHTTPClient = getHTTPClient(cfg.Logger, zccRateLimiter, cfg)

0 comments on commit d4f69fe

Please sign in to comment.