Fugly hack to make the tests pass for non-64-bit platforms #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fugly "fix" makes sure that the typedef test case ignores the 64bit types if the system does not support them. This is done using sizeof().
Right now the test replicates the expected output for 64bit systems. This is not good, but the only way to make the current setup work, as there can only be one expected outcome for each test.
The best solution would have been if the type sizes where strictly defined inside the interpreter, i.e. that the test case passes regardless of the type sizes of the host system (which I guess is the issue here).