Bugfix for quantum/dip_switch.c (qmk#8731)

* dipsw test on helix/rev2/sc/back:five_rows * bug fix quantum/dip_switch.c * test end. remove test code. Revert "dipsw test on helix/rev2/sc/back:five_rows" This reverts commit 4b13ebb. * dipsw test on helix/rev2/sc/back:five_rows * update quantum/dip_switch.c * test end. remove test code. Revert "dipsw test on helix/rev2/sc/back:five_rows" This reverts commit bf99ace.
zsa · May 24, 2020 · 308fbef · 308fbef
1 parent 76ac6ae
commit 308fbef
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/quantum/dip_switch.c b/quantum/dip_switch.c
@@ -59,13 +59,13 @@ void dip_switch_read(bool forced) {
     for (uint8_t i = 0; i < NUMBER_OF_DIP_SWITCHES; i++) {
         dip_switch_state[i] = !readPin(dip_switch_pad[i]);
         dip_switch_mask |= dip_switch_state[i] << i;
-        if (last_dip_switch_state[i] ^ dip_switch_state[i] || forced) {
+        if (last_dip_switch_state[i] != dip_switch_state[i] || forced) {
             has_dip_state_changed = true;
             dip_switch_update_kb(i, dip_switch_state[i]);
         }
     }
     if (has_dip_state_changed) {
         dip_switch_update_mask_kb(dip_switch_mask);
+        memcpy(last_dip_switch_state, dip_switch_state, sizeof(dip_switch_state));
     }
-    memcpy(last_dip_switch_state, dip_switch_state, sizeof(&dip_switch_state));
 }