Page thumbnails in PDF reader sidebar #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvasilak
requested changes
Dec 8, 2023
Zotero/Scenes/Detail/PDF/Views/PdfThumbnailsViewController.swift
Outdated
Show resolved
Hide resolved
| annotationsController.coordinatorDelegate = self.coordinatorDelegate | ||
| annotationsController.boundingBoxConverter = self.boundingBoxConverter | ||
| self.addChild(annotationsController) | ||
| let annotationsController = AnnotationsViewController(viewModel: viewModel) |
There was a problem hiding this comment.
Since we create several controllers when the document appears, that may not even be used at all, maybe we can convert them to lazy load, in a future update. Or maybe just pre-load the first, or some.
There was a problem hiding this comment.
I considered this to be pretty much the same as UITabbarController which allocates all controllers ahead too. But we can definitely improve this by lazy loading.
Just my memory I'm afraid :), I'll rename to uppercase. Fixed a56ffdb |
mvasilak
approved these changes
Dec 12, 2023
Co-authored-by: Miltiadis Vasilakis <[email protected]>
Co-authored-by: Miltiadis Vasilakis <[email protected]>
michalrentka
force-pushed
the
thumbnails
branch
from
a56ffdb to
2bc67d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #742