Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve annotations filter #807

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Improve annotations filter #807

merged 11 commits into from
Nov 21, 2023

Conversation

mvasilak
Copy link
Contributor

@mvasilak mvasilak self-assigned this Nov 14, 2023
michalrentka
michalrentka approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@michalrentka michalrentka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but if you could extract the color picker into separate view and just reuse the view in AnnotationsFilterViewController.swift and AnnotationToolOptionsViewController.swift instead of having the same code in both, that would be ideal.

@mvasilak mvasilak force-pushed the improve-annotations-filter branch from 0ac8cae to 939dd7f Compare November 18, 2023 15:35
@mvasilak
Copy link
Contributor Author

@michalrentka ready for another look. Created common widget that is used in all current use cases, and also fixed some related small UI bugs. In the future, if necessary, we could improve it by implementing the widget e.g. using a collection view, so layout would be more dynamic.

@mvasilak mvasilak force-pushed the improve-annotations-filter branch from 647963f to 4d1c7b2 Compare November 21, 2023 06:58
@mvasilak mvasilak force-pushed the improve-annotations-filter branch from 70f5ff7 to 4145fbd Compare November 21, 2023 14:22
@mvasilak mvasilak merged commit d560c4a into zotero:master Nov 21, 2023
1 check passed
@mvasilak mvasilak deleted the improve-annotations-filter branch November 21, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalrentka michalrentka michalrentka approved these changes

Assignees

@mvasilak mvasilak

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvasilak @michalrentka