-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove .unwrap() from JS API; Driver.new
=> new Driver
#142
Conversation
Driver.new
=> new Driver
Update, my wasm-bindgen PR was accepted, so we can commit to this change. It will presumably be released in version Please note that for the time being, using If you're just using |
Awesome! This is great news. |
ci: add wasm32-unknown-unknown target ci: duplicate wasm-bindgen downloader
90c5c69
to
2cb6a65
Compare
ci: add gitignore to wasm-pack replacement script ci: let the wasm-pack replacement script use --release
2cb6a65
to
f8aa020
Compare
This now includes a workaround for npm/cli#4126, which has caused a couple of canary builds to fail to publish. |
This is based on my nearly-finished wasm-bindgen PR rustwasm/wasm-bindgen#2710. It works!
It completely removes the
WasmResult
workaround for wasm-bindgen# 1963 that I devised previously, and all the annoying and difficult to remember.unwrap()
calls. A number of other workarounds are also no longer necessary:Driver.new
does not need to be a method, it can be a constructor i.e.new Driver
WasmResult
instead ofWasmResult<BibliographyMeta>
etc.So the upgrade guide for this is
Driver.new
withnew Driver
.unwrap()
cargo install fastmod
is always helpful for this.Misc
esbuild
instead of webpack