Fix #192 screenboard width and height should support string #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog API for screenboards width and height can return either numbers , number (like “1024”) strings or even strings (like “100%”). The recent fix zorkian#190 changed those fields to be only ints, breaking the compatibility with some datadog screen boards. As suggested in zorkian#192 this change fixes the issue by making the fields become `json.Number` which should cover all possible returned values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datadog API for screenboards width and height can return either numbers, number as strings (like “1024”) or even strings (like “100%”).
The recent fix #190 changed those fields to be only ints, breaking the compatibility with some datadog screen boards (notably the ones returning "100%").
As suggested in #192 this change fixes the issue by making the fields become
json.Numberwhich should cover all possible returned values.