2.9.x #3
Open
2.9.x #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds 8.1 to list of PHP constraints - Modifies how package replaces zend-mime: - Changes "replace" section to "conflict", and changes zend-mime constraint in that section to "*" - Removes laminas-zendframework-bridge as requirement - Bumps laminas-coding-standard to 2.2 series Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Also includes removal of file-level docblocks Signed-off-by: Matthew Weier O'Phinney <[email protected]>
We have a circular dependency scenario between laminas-mail and laminas-mime. laminas-mail depends on laminas-mime for its MIME parsing capabilities. laminas-mime decodes headers to a laminas-mail `Headers` instance. Unfortunately the `Headers` class implements `Iterator`, and, as such, we get deprecations under 8.1 unless the `#[ReturnTypeWillChange]` attribute to affected methods. The solution here is to temporarily inline the `Headers` class as a test asset until laminas-mail is updated to work on PHP 8.1. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
- We no longer need to exclude builds, as those PHP versions are no longer supported. - We DO need to ignore platform PHP requirements for PHP 8.1. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
First version providing HeaderLocator class Signed-off-by: Matthew Weier O'Phinney <[email protected]>
…s-mail implementation - Use `files` autoloader to load the local `Headers` version - Ensure that the import for `ReturnTypeWillChange` attribute is not removed by phpcs Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Provide PHP 8.1 support
Found this while testing laminas-mail; $wantedName has a default `null` value, which means that when calling `strtolower()` on that value, we may raise a deprecation notice under 8.1 as `null` values are no longer allowed to that function. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
…empty-string Do not pass null value to strtolower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.