Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data fetchers for SWR 2 #164

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Update data fetchers for SWR 2 #164

merged 2 commits into from
Dec 29, 2022

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Dec 14, 2022

SWR 2 no longer destructures fetcher key arrays as function args (see vercel/swr#1864.) Here, we pass the Caesar parameters straight through to the data fetcher as an object.

See #162.

@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Dec 14, 2022

Seems to work on a single subject: https://localhost:3000/view/workflow/3438/subject/134548

I'm seeing the correct GraphQL query posted to Caesar, which I think is what broke in #162.

SWR 2 no longer destructures fetcher key arrays as function args. Here, we pass the Caesar parameters straight through to the data fetcher as an object.
@eatyourgreens eatyourgreens merged commit 6503e33 into master Dec 29, 2022
@eatyourgreens eatyourgreens deleted the swr-2 branch December 29, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant