Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Copier: tweaks to initialization #4270

Merged
merged 8 commits into from
Mar 12, 2024
Merged
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/project_copier.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
class ProjectCopier
attr_reader :project_to_copy, :user

EXCLUDE_ATTRIBUTES = %i[classifications_count launched_row_order beta_row_order].freeze
EXCLUDE_ATTRIBUTES = %i[
classifications_count
classifiers_count
launch_date
completeness
activity
lock_version
launched_row_order
beta_row_order
].freeze

INCLUDE_ASSOCIATIONS = [
:tutorials,
:pages,
8 changes: 8 additions & 0 deletions spec/lib/project_copier_spec.rb
Original file line number Diff line number Diff line change
@@ -41,6 +41,14 @@
expect(copied_project.configuration['source_project_id']).to be(project.id)
end

it 'does not copy over excluded attributes' do
project_with_excluded_keys = create(:full_project, classifications_count: 3, classifiers_count: 2, launch_date: Date.yesterday, completeness: 0.5, activity: 1, lock_version: 8)
other_copied_project = described_class.new(project_with_excluded_keys.id, copyist.id).copy
ProjectCopier::EXCLUDE_ATTRIBUTES.each do |attr|
expect(other_copied_project[attr]).not_to eq(project_with_excluded_keys[attr])
end
end

it 'creates Talk roles for the new project and its owner' do
allow(TalkAdminCreateWorker).to receive(:perform_async)
copied_project