Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6.1 spec fixes- update error messages assertion when an invalid put operation #4142

Conversation

yuenmichelle1
Copy link
Collaborator

error message on an invalid put operation for users includes rails generated message
\nDid you mean? controller\n action\n id (in 6.1) vs just

"param is missing or the value is empty: users"

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@yuenmichelle1 yuenmichelle1 marked this pull request as ready for review March 13, 2023 14:46
@yuenmichelle1 yuenmichelle1 requested a review from zwolf March 13, 2023 14:46
Copy link
Member

@zwolf zwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Approved pull request label Mar 14, 2023
@yuenmichelle1 yuenmichelle1 merged commit a4d408e into master Mar 14, 2023
@yuenmichelle1 yuenmichelle1 deleted the rails-6.1-spec-fixes---users_controller_spec.rb-error-message-assertion-fix branch March 14, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants