v2.10.0 - upgrade to React 17 #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh thank gods the other dependencies could be updated with no issues. |
eatyourgreens
suggested changes
Jun 17, 2022
| "react": "^16.2.0", | ||
| "react-dom": "^16.2.0" | ||
| "react": "17.x", | ||
| "react-dom": "^17.x" |
There was a problem hiding this comment.
The peer dependencies should include React 16 and React 17. See Markdownz for an example.
|
I'm closing PR this since it's no longer too urgent - we have a workaround for PFE PR 6155, which is to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR upgrades the peer dependencies to React 17, and bumps the package to version 2.10.0
This repo may be deprecated, but it's still a dependency on Panoptes-Front-End. Its usage of React 16 is causing serious issues with the build process on Node 16.15. See zooniverse/Panoptes-Front-End#6155
Status