Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Google Analytics and react-native-google-analytics-bridge #402

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

mcbouslog
Copy link
Contributor

Fixes issues running app locally with Android Studio.

What this change should allow you to do:

  • run the app locally with Android Studio (Android Studio Chipmunk | 2021.2.1 Patch 1, node 10)

Review Checklist

  • Does it work in Android and iOS?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • Are tests passing?

@mcbouslog
Copy link
Contributor Author

These changes allow the app to run locally with Android Studio. Google Analytics isn't used, so this PR removes it and the related deprecated dependency that implemented it. See #281 and #172 for additional information regarding next steps for analytics.

Noting per #398 you don't have to run this locally but I think GitHub requires an approving review to be able to merge.

@chelseatroy chelseatroy merged commit aa90545 into video-subjects Jul 1, 2022
@mcbouslog mcbouslog deleted the remove-ga branch July 11, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants