Video subjects #389
Video subjects #389
Conversation
There was a problem hiding this comment.
This is great! Code looks good, works well on simulated iOS and Android devices.
One comment (related to the two instances the video component is used) related to repeating the video.
Not related to these changes, but maybe these changes cause it to continue to happen - in the ClassifierContainer.js, onFeedbackViewLayout, adding useNativeDriver: false after line 50 prevents a warning that otherwise continually logs.
|
I think this was noted elsewhere (Slack?), but some button text alignment may have changed: |
|
Possibly another separate issue to be opened, I'm getting the following error after swiping a video subject on Android: |
|
Hi @mcbouslog ! Yes, please open separate issue for the alignment, although anecdotally, we have had a few little alignment issues like that for as long as I've maintained this app (I clean them up as I see them). Not sure about that error an had a lot of trouble reproducing, so an issue there would be super helpful as well. |
I'm unable to recreate this issue on the beta version of the app on my Android device, please disregard. |
+ Still shows only a black screen in full screen mode + Still need to check that it works for single answer and multi answer question workflows + What do we do about the rectangle drawing task?
…nderstand where they sit in the hierarchy
…various structural changes necessary to get the app running with those changes + Includes a sed script that runs after dependency installation to fix a typo in react native that gets fixed in version 0.65. When we upgrade to 0.65 we'll probably want to remove that second sed command in the package.json postinstall script string.
…n system no longer depends on
…ndroid in the implementation
chelseatroy
force-pushed
the
video-subjects
branch
from
c16e461 to
ad8f1df
Compare
|
Closes #396 |
|
Closes #290 |
What this change should allow you to do:
ON a swipe layout project, you can now include video subjects! In staging, you can test this on the video subject workflow of the "All Mobile Workflows" project.
Review Checklist
rm -rf node_modules/ && npm installand app works as expected?My goals for this PR: