Fix Museum Mode Fast Tap Issue (appears to be specific to drawing workflow) #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter the first press until a new image loads + I also checked whether other workflows have this problem. I was not able to reproduce the issue in the other workflows.
chelseatroy
force-pushed
the
fix-museum-mode-fast-tap-submit
branch
from
7152298 to
7e74b3d
Compare
|
LGTM. Nice and succinct fix. I've posted a screenshot of the error message from the simulator in the original issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Children can mash the submit button all they want, but it disables after the first press until a new image loads
Fixes #310.
Invision Mock-ups:
Describe your changes.
Review Checklist
rm -rf node_modules/ && npm installand app works as expected?