-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only process footnote links if component is mounted #63
Conversation
@simensta any objections if I merge this? |
The code builds and the tests run successfully for me, but I am having trouble using npm link to test the package in Panoptes-Front-End. Is there another way to test the package in PFE? |
Good question. I don't actually know how to test a build of markdownz, come to think of it. |
I am now able to use
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My npm link setup is finally working! 🎉 Thank you for your help!
I worked through the classification interface (submitting a classification and loading a new subject) looking for the errors mentioned here: zooniverse/Panoptes-Front-End#4324 (comment). I didn't see any DOM warnings or console warnings pertaining to markdown footnotes.
During this review, I noticed that the footnote feature doesn't display the footnote text. This is true of this branch as well as markdownz master. I'll create an issue so that can be addressed separately.
Published as 7.4.2. |
displayName
.findDOMNode
with a ref.