Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cruft deps and update markdown-it-imsize #56

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

srallen
Copy link
Contributor

@srallen srallen commented Jun 6, 2017

Updates to the non-forked markdown-it-imsize and removes cruft from old browserify and webpack setups as well as react-mixin. I'm not sure why webpack was added or when it was used since the babel CLI is used for the build task and there's no webpack config defined. Not sure if this will fix the issue with travis with the node update, but I'll install this branch to that branch to test it out.

@srallen srallen requested a review from eatyourgreens June 6, 2017 17:11
Copy link
Contributor

@eatyourgreens eatyourgreens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm in Scotland the rest of the week, so maybe @rogerhutchings should give it a once over too.

@srallen srallen merged commit 11f1d0a into master Jun 19, 2017
@srallen srallen deleted the remove-cruft-update-dep branch June 19, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants