Use callback for refs and use enzyme #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests are passing now. We may want to rethink the tests where I had to call We shouldn't be essentially retesting react. |
srallen
changed the title
test/markdown-editor-test.jsx
Outdated
| import { MarkdownEditor } from '../src/index'; | ||
|
|
||
| function mockTextarea() { | ||
| const mockTextarea = () => { |
There was a problem hiding this comment.
I'm not sure why this is assigning an anonymous function to a variable, rather than just declaring mockTextArea as a function.
|
One small comment about declaring a function. Otherwise, looks good. |
eatyourgreens
approved these changes
May 18, 2017
|
@eatyourgreens that was me trying to figure out why it was a function in the first place and making it an object and then figuring out that it needed to be one for some of the tests. Should be good to go now. |
|
By the way, I've included this update in https://react-15.pfe-preview.zooniverse.org/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the editor to use a callback rather than the string literal for refs. The way the tests were written depended on a string ref, so I went through and converted the tests to use enzyme which has a much nicer test API. All but three tests are passing, so I hope to get to this during down time this week.