Require spacing for @-mentions #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Staged version can be found here: https://fix-mention-parsing.pfe-preview.zooniverse.org |
|
Derp.. Just broke it. One sec.... |
|
Okay, staged version is fixed now |
|
Just saw that this was an issue on zooniverse/Panoptes-Front-End#3241 too, so I updated the other mentions to be consistent as well. This will match the behavior of the API implementation of the mention parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For zooniverse/Panoptes-Front-End#3260.
Instead of attempting to use boundary characters in the match (which never made sense here), it just requires a leading space or a line-start.
It will break mention parsing in non-spaced usages. e.g.
"Hi @user"works, but"Hi (@user)"will not