React 15 #47
Merged
React 15 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React 15 enforces using defaultValue or value, but not both, on form controls.
6 tasks
|
This should be merged as part of zooniverse/Panoptes-Front-End#2984 to keep the React versions in synch. |
|
Cool. I'm taking a look at both PRs this morning. |
srallen
approved these changes
Nov 11, 2016
rogerhutchings
approved these changes
Nov 11, 2016
|
LGTM - I'll leave the PR open, as it'll need a version bump as well |
|
Merging now, as there's a version bump as part of #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the React packages to 15.3 and removes
defaultValuefrom the editor.