Remove replaceSymbols method, add transform prop

[brian-c]

This removes the replaceSymbols method and moves its behavior into a transform prop. That way we can pass in the current router so we can generate links in the proper context.

Once this is merged, let's bump the version and publish, and then I'll update zooniverse/Panoptes-Front-End#1408, which closes #8.

[edpaget]

I'd really prefer the transform to remain as a hardcoded part of the Markdown component, but I do want to pass in the project as a props instead of getting them from the router content. I think it'd be useful to render Markdown with links to subjects/hashtags/users (whatever else we add) from anyplace we use markdown on the site.

[edpaget]

Also wrt to the Travis failure it seems that occassionally sauce times out waiting for a particular vm or two.

[brian-c]

Hashtags and @-mentions aren't part of Markdown, so I'd argue they don't belong in this component, and if we can avoid binding our components to Panoptes, I think we should.

This'll work anywhere on the site with no modification since I'm overriding the default transform function. in that PFE PR.

[edpaget]

I'd argue they they're part of Zooniverse Markdown, so they really should be included. I don't really see why we wouldn't bind our components to Panoptes, since it'll be the basis for Zooniverse projects for the foreseeable future, and we set out to build components for the Zooniverse instead of a generic React component toolkit.

[edpaget]

In addition, it's it more flexible to just pass a project when we want project-dependent links instead of having to have them in the URL?

[brian-c]

I don't really get it, since the links that we're generating in the transform step are specific to zooniverse.org.

What interface do you have in mind? <Markdown content="..." router={router} project={project} />?

[edpaget]

No I'd just pass in <Markdown content="..." project={project}> not sure you'd need the router at all in that case. I'm not sure why we wouldn't links to go back to zooniverse.org?

[aweiksnar]

I think replaceZooniverseSymbols would be cool to export from here, and have as an optional-but-default transform prop, so it'd still be tested, versioned, and supplied in here, but also not enforced on consumers of the lib

[edpaget]

Yeah I agree with @aweiksnar and I think that was what I proposed on slack.