Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-root: Remove stub routes #6340

Merged
merged 3 commits into from
Sep 27, 2024
Merged

app-root: Remove stub routes #6340

merged 3 commits into from
Sep 27, 2024

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Sep 25, 2024

Package

app-root

Linked Issue and/or Talk Post

Corresponds to #6335
Toward: #6331

Describe your changes

  • We do NOT want search engines to find stub routes in the app such as /projects so I removed those.
  • The liveness probe of app-root previously relied on /users but there's no page at that route so I changed it to /about.

How to Review

  • This is mainly tested by the CI builds and we'll need to check that fe-root.preview deploys correctly.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)

@goplayoutside3 goplayoutside3 requested review from zwolf and a team September 25, 2024 18:07
@coveralls
Copy link

coveralls commented Sep 25, 2024

Coverage Status

coverage: 78.557% (+0.04%) from 78.515%
when pulling fabb223 on remove-stub-pages
into 79c80fa on master.

@goplayoutside3 goplayoutside3 changed the title app-root: Remove app-root robots.txt and stub routes app-root: Remove stub routes Sep 26, 2024
@github-actions github-actions bot added the approved This PR is approved for merging label Sep 27, 2024
@goplayoutside3
Copy link
Contributor Author

This will be deployed alongside zooniverse/static#380 on Monday 👍

@goplayoutside3 goplayoutside3 merged commit 5267028 into master Sep 27, 2024
8 checks passed
@goplayoutside3 goplayoutside3 deleted the remove-stub-pages branch September 27, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants