Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage: build a PreviewLayout of user groups in UserHome #6129

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Jun 11, 2024

Package

lib-user
app-root

Linked Issue and/or Talk Post

Coincides with #6121 and #6125 to complete the signed-in homepage design

Describe your changes

How to Review

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

@goplayoutside3 goplayoutside3 added the enhancement New feature or request label Jun 11, 2024
@goplayoutside3 goplayoutside3 requested a review from mcbouslog June 11, 2024 02:26
@coveralls
Copy link

Coverage Status

coverage: 79.15% (+0.008%) from 79.142%
when pulling e6b6cf9 on homepage-groups-preview
into b4935ba on master.

@mcbouslog mcbouslog self-assigned this Jun 13, 2024
@coveralls
Copy link

Coverage Status

coverage: 79.17% (-0.03%) from 79.203%
when pulling 57a10a4 on homepage-groups-preview
into f1e524f on master.

@coveralls
Copy link

Coverage Status

coverage: 79.189% (-0.03%) from 79.214%
when pulling f80440d on homepage-groups-preview
into 37bef25 on master.

Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Refactored so group displayName showed, as ul, and sorted by created_at to show recently created (active membership) groups show first on homepage.

@github-actions github-actions bot added the approved This PR is approved for merging label Jun 17, 2024
@mcbouslog mcbouslog merged commit 81eb200 into master Jun 17, 2024
9 checks passed
@mcbouslog mcbouslog deleted the homepage-groups-preview branch June 17, 2024 14:47
@coveralls
Copy link

Coverage Status

coverage: 79.18% (-0.03%) from 79.214%
when pulling ecfa6b2 on homepage-groups-preview
into 37bef25 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants