-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-project: Add OrganizationLink to ProjectHeader and Hero components #4567
Conversation
I might combine this PR, #4569 and PR to Add OrganizationLink to Hero into one PR. |
...ges/app-project/src/components/ProjectHeader/components/OrganizationLink/OrganizationLink.js
Outdated
Show resolved
Hide resolved
.../src/screens/ProjectHomePage/components/Hero/components/OrganizationLink/OrganizationLink.js
Outdated
Show resolved
Hide resolved
Open items to follow-up on:
cc: @seanmiller26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
packages/app-project/src/screens/ProjectHomePage/ProjectHomePage.js
Outdated
Show resolved
Hide resolved
packages/app-project/src/screens/ProjectHomePage/ProjectHomePage.js
Outdated
Show resolved
Hide resolved
f6e67b1
to
c0d883a
Compare
Pending refactor with organization store
I’ve already approved this once. Please do feel free to merge it with changes. |
@seanmiller26 - these changes now include an organization link throughout a project's paths (home, classify, about) and in the DropdownNav with a small screen. When you get a chance you can check it out at:
Let me know what you think! |
The one note I'd point out is that "From the Organization: xyz" remains untranslated in different languages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great!
@eatyourgreens - there's been some substantive changes since your review, would you mind taking another look when you get a chance? No rush. |
Package
Linked Issue and/or Talk Post
Describe your changes
fetchOrganization
helpergetStaticPageProps
withfetchOrganization
How to Review
Helpful explanations that will make your reviewer happy:
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
New Feature
Refactoring
Post-merge