Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-project: Add OrganizationLink to ProjectHeader and Hero components #4567

Merged
merged 16 commits into from
Jun 12, 2023

Conversation

mcbouslog
Copy link
Contributor

@mcbouslog mcbouslog commented May 4, 2023

Package

  • app-project

Linked Issue and/or Talk Post

Describe your changes

  • add fetchOrganization helper
  • refactor getStaticPageProps with fetchOrganization
  • add organization store
  • add OrganizationLink to ProjectHeader
  • add OrganizationLink to Hero's NarrowLayout and WideLayout
  • add organization link to DropdownNav

How to Review

Helpful explanations that will make your reviewer happy:

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

New Feature

  • The PR creator has listed user actions to use when testing the new feature
  • Unit tests are included for the new feature
  • A storybook story has been created or updated
    • Example of SlideTutorial component with docgen comments, and its story

Refactoring

  • The PR creator has described the reason for refactoring
  • The refactored component(s) continue to work as expected

Post-merge

  • This PR adds translations keys to English dictionary(s). See guidance for pulling new keys to Lokalise here.

@mcbouslog mcbouslog requested a review from a team May 4, 2023 20:58
@coveralls
Copy link

coveralls commented May 4, 2023

Coverage Status

coverage: 82.06% (+0.04%) from 82.018% when pulling eeb6b90 on app-project-fetchOrganization into e4bf598 on master.

@mcbouslog
Copy link
Contributor Author

I might combine this PR, #4569 and PR to Add OrganizationLink to Hero into one PR.

@mcbouslog mcbouslog changed the title app-project: Add fetchOrganization helper app-project: Add OrganizationLink to ProjectHeader and Hero components May 5, 2023
@mcbouslog
Copy link
Contributor Author

mcbouslog commented May 11, 2023

Open items to follow-up on:

  • desktop view, show organization link in project header when on classify and about pages
  • mobile view, remove organization link from project header or move organization link to project nav dropdown

cc: @seanmiller26

eatyourgreens
eatyourgreens previously approved these changes May 31, 2023
Copy link
Contributor

@eatyourgreens eatyourgreens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot added the approved This PR is approved for merging label May 31, 2023
@eatyourgreens eatyourgreens force-pushed the app-project-fetchOrganization branch from f6e67b1 to c0d883a Compare May 31, 2023 13:52
@mcbouslog mcbouslog removed the approved This PR is approved for merging label Jun 2, 2023
@mcbouslog mcbouslog dismissed eatyourgreens’s stale review June 2, 2023 16:37

Pending refactor with organization store

@eatyourgreens
Copy link
Contributor

I’ve already approved this once. Please do feel free to merge it with changes.

@mcbouslog mcbouslog requested a review from seanmiller26 June 9, 2023 21:45
@mcbouslog
Copy link
Contributor Author

@seanmiller26 - these changes now include an organization link throughout a project's paths (home, classify, about) and in the DropdownNav with a small screen.

When you get a chance you can check it out at:

Let me know what you think!

@seanmiller26
Copy link
Contributor

The one note I'd point out is that "From the Organization: xyz" remains untranslated in different languages.

Copy link
Contributor

@seanmiller26 seanmiller26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great!

@github-actions github-actions bot added the approved This PR is approved for merging label Jun 12, 2023
@mcbouslog
Copy link
Contributor Author

@eatyourgreens - there's been some substantive changes since your review, would you mind taking another look when you get a chance? No rush.

@mcbouslog mcbouslog requested a review from eatyourgreens June 12, 2023 19:12
@mcbouslog mcbouslog merged commit 583c99d into master Jun 12, 2023
@mcbouslog mcbouslog deleted the app-project-fetchOrganization branch June 12, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging
Projects
Development

Successfully merging this pull request may close these issues.

Links to related organization from project home page
4 participants