Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild lib-auth package lock #410

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Rebuild lib-auth package lock #410

merged 1 commit into from
Jan 31, 2019

Conversation

eatyourgreens
Copy link
Contributor

Run a fresh install of all dependencies for lib-auth.

Package: lib-auth

Closes #363.

Review Checklist

General

  • Are the tests passing locally and on Travis?
  • Is the documentation up to date?
  • Is the changelog updated?

Apps

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?

Run a fresh install of all dependencies.
@eatyourgreens
Copy link
Contributor Author

I deleted package-lock.json from packages/lib-auth, then ran the bootstrap script to create a fresh package lock. This updates har-validator to a version that actually exists, but also upgrades babel (and other dependencies.)

@eatyourgreens
Copy link
Contributor Author

lib-auth tests all pass for me on this branch, and I can start the classifier without errors.

@srallen srallen merged commit bfa4626 into master Jan 31, 2019
@srallen srallen deleted the rebuild-auth-deps branch January 31, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants