This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
Fixes behavior referenced in #38 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that makes some sense. Does this replace #38? |
|
Yea, #38 would be unnecessary. |
|
That's a much nicer solution! |
|
Anyone have an issue with me merging this? |
|
Nope, looks good to me. |
chrissnyder
added a commit
that referenced
this pull request
Jul 16, 2014
Fixes behavior referenced in #38
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My brain starts to go in circles when I keep looking at this, so I might say something horribly incorrect here.
But what it looks like to me is that 14ad24a caused the issue. When a new SubjectForRecent was created, it iterated over all properties, including the Subject constructor. So when it got to the point of adding the instances to the instances array, the object was actually a Subject.
This partially reverts the change, but allows the params set to be flexible. So the "selected_light_curve" property needed for PH still is fine.