Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

addEventListener breaks in IE8 #27

Closed
eatyourgreens opened this issue Jan 14, 2014 · 5 comments
Closed

addEventListener breaks in IE8 #27

eatyourgreens opened this issue Jan 14, 2014 · 5 comments
Labels

Comments

@eatyourgreens
Copy link
Contributor

controllers/dropdown.coffee is breaking in IE8 because addEventListener is undefined. Spotted by Luke in war diaries, but also seems to affect Space Warps and Plankton.

@chrissnyder
Copy link
Contributor

Most of our sites only support IE > 8. I'd be surprised if any recent ones work on 8. Current Zooniverse library is definitely targeted at IE > 8.

@eatyourgreens
Copy link
Contributor Author

Yeah, when Luke first told me in broke in IE8 on XP, my first thought was
"who uses IE8". His boss apparently.

I think browser-dialog.js might still pass IE8 as supported, so maybe just
bump that up to 9?

On Tue, Jan 14, 2014 at 2:00 PM, Chris Snyder [email protected]:

Most of our sites only support IE > 8. I'd be surprised if any recent ones
work on 8. Current Zooniverse library is definitely targeted at IE > 8.


Reply to this email directly or view it on GitHubhttps://github.com//issues/27#issuecomment-32266272
.

@chrissnyder
Copy link
Contributor

Ouch. Not much I can do about his boss still on IE8, but I did bump the supported IE version to 9 in aa8560c

@brian-c
Copy link
Contributor

brian-c commented Jan 14, 2014

FYI, those numbers are configurable per instance.

@eatyourgreens
Copy link
Contributor Author

Cool. In the end I showed the browser warning to browsers that throw an exception:

BrowserDialog = require 'zooniverse/controllers/browser-dialog'

try
  Api = require 'zooniverse/lib/api'
  User = require 'zooniverse/models/user'
  Group = require 'zooniverse/models/project-group'
  TopBar = require 'zooniverse/controllers/top-bar'
catch e
  BrowserDialog.show()

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants