Skip to content
This repository has been archived by the owner on Mar 25, 2019. It is now read-only.

Switch underscore to hyphen for Chinese language nav. #260

Merged
merged 1 commit into from
May 7, 2016

Conversation

willettk
Copy link
Contributor

Follow-up to #254. Renaming the file worked, but users can't get there through the language switching tab.

Eg:

https://www.galaxyzoo.org/?lang=zh_tw fails

but

https://www.galaxyzoo.org/?lang=zh-tw succeeds.

@willettk
Copy link
Contributor Author

willettk commented Apr 20, 2016

I haven't tested if this should also be applied to zh_cn, by the way.

@eatyourgreens
Copy link
Contributor

Looks good to me. I assume zh_cn will need the same change.

@willettk willettk merged commit 3af05ab into master May 7, 2016
@willettk
Copy link
Contributor Author

willettk commented May 7, 2016

Merged. Are changes like this automatically deployed, or does that need to be done manually?

@willettk willettk deleted the chinese_fix branch May 7, 2016 23:04
@eatyourgreens
Copy link
Contributor

Manually. I think Galaxy Zoo needs an older node/npm setup to deploy properly too.

@willettk
Copy link
Contributor Author

willettk commented May 8, 2016

Thanks, @eatyourgreens. Can we tag someone on the dev team to do that?

On Sun, May 8, 2016 at 3:50 PM eatyourgreens [email protected]
wrote:

Manually. I think Galaxy Zoo needs an older node/npm setup to deploy
properly too.


You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub
#260 (comment)

Dr. Kyle Willett
Research Associate
School of Physics and Astronomy
University of Minnesota

@eatyourgreens
Copy link
Contributor

I thought that was you @willettk 😄 Adam is having a look. Should be deployed soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants