Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle no credentials config #14

Merged
merged 1 commit into from
Apr 16, 2022
Merged

handle no credentials config #14

merged 1 commit into from
Apr 16, 2022

Conversation

nicholashu
Copy link
Contributor

allows the plugin to work when an ECS task role is handling permission instead of exposing a key and secret.

@zoomoid
Copy link
Owner

zoomoid commented Apr 13, 2022

Does the S3 Client require the absence of the "credentials" property entirely or is leaving the accessKeyId and secretAccessKey values as undefined maybe enough? I haven't seen unauthenticated access to a bucket ever being used.

@zoomoid zoomoid merged commit aabd2ac into zoomoid:main Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants