fix: CI on a supported platform #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis CI is no longer a platform this project can build on, so I moved it to CircleCI where we can leverage the matrix feature for multiple platforms. Running the CI jobs on multiple platforms revealed a bug in a test where Windows was not using \r\n line endings.
|
I think we should switch to Github Action. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis CI is no longer a platform this project can build on, so I moved it to CircleCI where we can leverage the matrix feature for multiple platforms.
Running the CI jobs on multiple platforms revealed a bug in a test where Windows was not using \r\n line endings.
Sorry that the formatter changed so much in the test file, but the meat of the change is in lines 2120-2130.