Don't panic (on general section for empty ini) #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new ini or loading it from an input which contains no actual entries but empty lines for the general section, calling general_section and general_section_mut panics. This is not documented nor do I expect this behavior: Isn't an empty file equivalent to an empty general section? And from this perspective, calls to general_section or general_section_mut should not panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
general_section()andgeneral_section_mut()on new ini or one loaded from an empty file panics as shown by c2ccbefgeneral_section()andgeneral_section_mut()Ini::default()new(),default(),load_...(), and so on