Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ordered-multimap #74

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Bump ordered-multimap #74

merged 2 commits into from
Sep 30, 2020

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Sep 24, 2020

And also remove extern crate ini; from the example 🙂

No longer necessary since this crate is using the 2018 edition.
@marioortizmanero
Copy link
Contributor

Is dependabot not integrated here? It could be helpful

@jplatte
Copy link
Contributor Author

jplatte commented Sep 24, 2020

dependabot doesn't seem to be used that much in the Rust ecosystem. IME breaking change releases more often than not require manual work anyway, and aren't that frequent so there's not that much value in it.

@marioortizmanero
Copy link
Contributor

marioortizmanero commented Sep 24, 2020

I've seen dependabot on quite a few libraries hosted on github. At the very least it serves as a notification to know a new breaking release is out. Otherwise I wouldn't know (and this exact release didn't need any manual work)

@jplatte
Copy link
Contributor Author

jplatte commented Sep 24, 2020

Sure, though also I just realized that that release (which only contained another release bump I also made a PR for) might not have been sufficient motivation for 0.3.0 rather than another patch release anyway... sgodwincs/ordered-multimap-rs#10 (comment)

I'll update this issue again when that's resolved, for now please don't merge yet 😅

@jplatte
Copy link
Contributor Author

jplatte commented Sep 30, 2020

ordered-multipap isn't part of this crate's public API, right? If so, seems like it makes more sense to just use 0.3 and be done with it.

@zonyitoo
Copy link
Owner

So I can merge it this PR now?

@jplatte
Copy link
Contributor Author

jplatte commented Sep 30, 2020

Yeah.

@zonyitoo zonyitoo merged commit 4eebbad into zonyitoo:master Sep 30, 2020
@jplatte
Copy link
Contributor Author

jplatte commented Sep 30, 2020

Thanks! Will there be a 0.16.0 release (or even 0.15.4 with just this change) soon?

@zonyitoo
Copy link
Owner

Will definitely be released in 0.16.0. This is a breaking change for 0.15.x.

@jplatte
Copy link
Contributor Author

jplatte commented Sep 30, 2020

I see. Is there an ETA for 0.16.0?

@zonyitoo
Copy link
Owner

Well, v0.16.0 is published already.

@jplatte
Copy link
Contributor Author

jplatte commented Sep 30, 2020

Ah, nice! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants