Fix return type #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtuin
reviewed
Feb 2, 2023
| @@ -240,7 +240,7 @@ final public function getDecodedContent(): string | |||
| /** | |||
| * Get raw message content. | |||
| */ | |||
| final protected function doGetContent(string $partNumber): string | |||
| final protected function doGetContent(string $partNumber): ?string | |||
There was a problem hiding this comment.
@roy-bongers Dit fixed de return type error, maar is dit geen issue in de imap2 library die null teruggeeft maar eigenlijk bijvoorbeeld false of "" terug moet geven?
There was a problem hiding this comment.
Tja, zeg 't maar. Hij komt hier in terecht of in de php-imap (library) imap_fetchbody functie. Die heb ik lokaal echter niet draaien. php.net zegt dat deze string|false returned: https://www.php.net/manual/en/function.imap-fetchbody.php
We zouden achter die twee returns ?? '' kunnen plakken, dan is 't ook gefixt I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sentry.io/organizations/zonneplan/issues/3900936630/?project=105836&query=is%3Aunresolved&referrer=issue-stream