Make config path dynamic according to package.json #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobisjan
requested changes
Sep 8, 2020
There was a problem hiding this comment.
Thanks @ming-codes for making this 👍, just left minor question.
blueprints/ember-web-app/index.js
Outdated
| @@ -15,6 +15,19 @@ module.exports = { | |||
| }; | |||
| }, | |||
|
|
|||
| fileMapTokens() { | |||
| const absPath = this.project.configPath(); // I can use this, but relative is better | |||
There was a problem hiding this comment.
Why is relative better?
Would it make sense to describe the reason in comment instead?
There was a problem hiding this comment.
😂Fragments of a reminder for myself when I got distracted. Anyway...
The file path is actually logged to the console when you generate the file. It can get long and wouldn’t be very useful to see the full path.
I can add a better explanation
bobisjan
approved these changes
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #582