Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ember-web-app-rename removal from after install hook #47

Closed
bobisjan opened this issue Dec 28, 2018 · 1 comment
Closed

Remove ember-web-app-rename removal from after install hook #47

bobisjan opened this issue Dec 28, 2018 · 1 comment
Milestone
v3.0.0

Comments

@bobisjan
Copy link
Contributor

bobisjan commented Dec 28, 2018 •
edited
Loading

Is this still needed to be handled here? 🤔

https://github.com/zonkyio/ember-web-app/blob/master/blueprints/ember-web-app/index.js#L13

Should be https://github.com/san650/ember-web-app-rename deprecated itself and users will be notified to update ember-web-app from that add-on?

/cc @san650
@bobisjan bobisjan added this to the v3.0.0 milestone Dec 28, 2018
@san650
Copy link
Contributor

san650 commented Dec 31, 2018

@bobisjan I think it's safe now to remove that logic. I'll deprecate ember-web-app-rename, good call.

bobisjan added a commit that referenced this issue Jan 5, 2019
@bobisjan
Merge pull request #50 from zonkyio/after-install-cleanup
2b8c95e 
Remove after install hook from blueprint, close #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
2 participants
@bobisjan @san650