Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and housekeeping #50

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Update dependencies and housekeeping #50

merged 4 commits into from
Jul 22, 2024

Commits on Jul 22, 2024

  1. Fix Ruby 3.4.0 deprecation warning: 

    ```
/Users/rschneeman/.gem/ruby/3.3.1/gems/get_process_mem-0.2.7/lib/get_process_mem.rb:2: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of get_process_mem-0.2.7 to add bigdecimal into its gemspec.
```
    @schneems
    schneems committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    7e3f467 View commit details
    Browse the repository at this point in the history

  2. Add CI and standard linting

    @schneems
    schneems committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    72cd215 View commit details
    Browse the repository at this point in the history

  3. Apply standard auto formatting 

    Adjust named regex group

```
$ be standardrb --fix
standard: Use Ruby Standard Style (https://github.com/standardrb/standard)
  Rakefile:8:1: Lint/UselessAssignment: Useless assignment to variable - `test_task`.
  lib/get_process_mem.rb:99:18: Lint/MixedRegexpCaptureTypes: Do not mix named captures and numbered captures in a Regexp literal.
```
    @schneems
    schneems committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    8573b6d View commit details
    Browse the repository at this point in the history

  4. Minimum is now 2.6 

    Getting an error with 2.5 on CI

```
Your RubyGems version (2.7.6.3) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`
```

It's easier to rev the version than to work around the problem
    @schneems
    schneems committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    e8382f4 View commit details
    Browse the repository at this point in the history