added delegate for the new finish method that's in RN 0.38 which calls the completion handler

[npomfret]

facebook/react-native#8040

[npomfret]

Now that RN 0.38 is released is anyone able to review this PR for me? I use it in production from my fork, as far as I can see its works well.

[npomfret]

@zo0r hey - would you mind reviewing this? It's a small change, required for iOS only (does nothing on android).

RN38 changed the method thats called when receiving a push notification. The purpose is to add a mechanism that tells the OS that the app has finished processing the notification. I've added a finish() method to the notification as advised in the RN docs.

Without this change, the OS can penalise you app and will stop delivering notifications.

[balazsnemeth]

+1 to merge this @zo0r

[npomfret]

@zo0r i've been using this in my app for a while, I think it's safe to merge.

[eddnav]

+1 here please @zo0r, I have this monkey patched in my app atm :/

[antonsivogrivov]

I need it too

[antonsivogrivov]

@zo0r, what's the problem here to merge this PR?

[antonsivogrivov]

@zo0r, thanks and what about npm release?

[eddnav]

Thank you! no more monkey patching! I was about to fork this last week and publish it to npm because sometimes I'd forget to remonkey patch 👍

[zo0r]

@tonygriv @eddnav 3.0.2 published to npm